Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix zk-counters checks with :LT #235

Merged
merged 1 commit into from
Jan 24, 2023
Merged

fix zk-counters checks with :LT #235

merged 1 commit into from
Jan 24, 2023

Conversation

krlosMata
Copy link
Contributor

This PR does the following:

  • remove LT binary state-machine with JMPN since values to check are <32 bits
  • removes issue regarding negative values in binary state-machine

@cla-bot cla-bot bot added the cla-signed label Jan 24, 2023
ignasirv
ignasirv approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@ignasirv ignasirv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@krlosMata krlosMata merged commit e488704 into develop Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ignasirv ignasirv ignasirv approved these changes

@laisolizq laisolizq Awaiting requested review from laisolizq laisolizq is a code owner

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krlosMata @ignasirv